-
Notifications
You must be signed in to change notification settings - Fork 63
A third episode option for accuracy #246
Comments
This is not possible currently. I'll elaborate on a better solution expanding on your issue. And how to fix this the correct way. Sonarr/Plex and many other services depend on thexem.info thexem.info has mappings of anidb to tvdb and to scene/p2pscene releases. This is what sonarr/plex use for metadata mapping. Notice in that list anidb. Well anidb also happens to have a public api, said API also has the ability to list a shows and match titles to the title in crunchyroll. This is because anidb has the url of hte japanesse version of each episode in its DB. If crunchy-cli just allowed us to connect to anidb. It can pass the url of the japanesse audio stream of the current episode your downloading to anidb and get the correct episode/season number of said and return it. This would 100% correct all issues with numbering when doing entire series archiving |
an option to have relative episode number with out episode 0s or .5s would also be a fix to the main issue, but using that anidb connection would also be amazing. |
After a bit of searching multiple problems occurred. It is not guaranteed that the Crunchyroll title is the same as the title in AniDB. For example if you're located in Germany, only the german dub of sword art online is available and every season of it has a |
Well in this case I think it should just be dropped, Episode 1 here is a single episode that includes both episode 1a and 1b, But overall I think cause how letters are used by crunchyroll they should come out as be spit out as 1a and 1b |
I've added a option which should handle the most cases. You can test it by cloning the repo and checking out the |
I'll try and find some time to test it sounds awesome tysm! |
Still doing some testing but this is what i'm seeing so far:
Idk which parts of that is related to this specific branch but just thought i'd mention the issues |
i think it would be nice if this option named anything that is a float as a special instead, that would solve 100% of the issue on my end since most of the time these episodes are classed as specials regardless, same goes for "1a" type episodes, if it returns sequence_number "anything.anything" make it a special |
That also would probably be the best solution for me, and another option for 1a and 1b episodes would be outputting them as e1p1 and e1p2 possibly, but with how rare they are putting them in special is probably a good bet too |
I think everything of the named issues are resolved now. Could you verify my changes? |
How should an episode be marked as special? |
The best way would be if the season for that episode could be set to special or 00 |
Yep just tested the new commit and all 4 of those issues are fixed, tysm! |
if it is a float number, set its sequence number to just the word "special", since lots of metadata providers dont follow half episodes are more the common "special - title" format, such as adventure time (not applicable of course but just off the top of my head) though this would likely fit better in its own flag that could work in tandem with relative sequence, maybe something named rename_floats or something |
Okay I see. I don't like the idea of an extra flag for this but I can't see another way atm. To give a good amount of flexibility, the extra flag could be designed exactly like E.g. (assuming that the new flag is called $ crunchy-cli archive -o "S{season_number}E{relative_sequence_number} - {title}.mkv" -os "Special - {title}.mkv" ...
# S1E1 - ep1.mkv
# S1E2 - ep2.mkv
# Special - ep2.5.mkv
# S1E3 - ep3.mkv How do you thing about this? |
yeah that looks great! |
That looks awesome thank you so much |
would there be anyway to make a flag to just ignore those episodes as well? Like how skip existing has one? |
I've pushed new code to the PR which adds the |
Support for this landed in v3.1.0 |
Thank you so much, I have been busy with school so I haven't been able to test this yet but it looks perfect |
Is your feature request related to a problem? Please describe.
As was stated by me in #206 and ohitstom in #241, having the numbers grow with {episode_number} and only having relative numbers with {relative_episode_number} has major issues with media servers like plex or jellyfin, because they don't check for numbers relative to the show or the season, so a season 2 with an episode 0 or a .5 episode is gonna be named entirely wrong to a point where I would have to go and rename 12+ episodes a season.
Describe the solution you'd like
The first solution that comes to mind would just be a accurate relative episode option that would set the episode number to exactly what it would be in the seasons. another option would be to be have a setting to ignore 0 and .5 episodes.
Additional context
For right now i'm probably gonna right a little script that just takes the episodes and subtracts it from the total of episodes from the previous seasons minus any 0 or .5 episodes. i understand this is an issue with how crunchy roll numbers their episodes (some with resets between seasons and some not) but rather than requiring a separate script it would be amazing to have this baked right in.
The text was updated successfully, but these errors were encountered: