Add return types to getter and fluent setter (OpenAPITools#5348)

* Add return types to getter and fluent setter * Add build example output
crunchbase · Feb 25, 2020 · c0fcffd · c0fcffd
1 parent b05df5d
commit c0fcffd
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/modules/openapi-generator/src/main/resources/php-symfony/model_generic.mustache b/modules/openapi-generator/src/main/resources/php-symfony/model_generic.mustache
@@ -23,7 +23,7 @@ class {{classname}} {{#parentSchema}}extends {{{parent}}} {{/parentSchema}}
      *
      * @return {{{vendorExtensions.x-comment-type}}}{{^required}}|null{{/required}}
      */
-    public function {{getter}}()
+    public function {{getter}}(){{#vendorExtensions.x-parameter-type}}: {{^required}}?{{/required}}{{vendorExtensions.x-parameter-type}}{{/vendorExtensions.x-parameter-type}}
     {
         return $this->{{name}};
     }
@@ -35,7 +35,7 @@ class {{classname}} {{#parentSchema}}extends {{{parent}}} {{/parentSchema}}
      *
      * @return $this
      */
-    public function {{setter}}({{#vendorExtensions.x-parameter-type}}{{vendorExtensions.x-parameter-type}} {{/vendorExtensions.x-parameter-type}}${{name}}{{^required}} = null{{/required}})
+    public function {{setter}}({{#vendorExtensions.x-parameter-type}}{{vendorExtensions.x-parameter-type}} {{/vendorExtensions.x-parameter-type}}${{name}}{{^required}} = null{{/required}}){{#vendorExtensions.x-parameter-type}}: {{^required}}?{{/required}}{{vendorExtensions.x-parameter-type}}{{/vendorExtensions.x-parameter-type}}
     {
         $this->{{name}} = ${{name}};
 

diff --git a/samples/server/petstore/php-symfony/SymfonyBundle-php/Model/Order.php b/samples/server/petstore/php-symfony/SymfonyBundle-php/Model/Order.php
@@ -185,7 +185,7 @@ public function setQuantity($quantity = null)
      *
      * @return \DateTime|null
      */
-    public function getShipDate()
+    public function getShipDate(): ?\DateTime
     {
         return $this->shipDate;
     }
@@ -197,7 +197,7 @@ public function getShipDate()
      *
      * @return $this
      */
-    public function setShipDate(\DateTime $shipDate = null)
+    public function setShipDate(\DateTime $shipDate = null): ?\DateTime
     {
         $this->shipDate = $shipDate;
 

diff --git a/samples/server/petstore/php-symfony/SymfonyBundle-php/Model/Pet.php b/samples/server/petstore/php-symfony/SymfonyBundle-php/Model/Pet.php
@@ -143,7 +143,7 @@ public function setId($id = null)
      *
      * @return OpenAPI\Server\Model\Category|null
      */
-    public function getCategory()
+    public function getCategory(): ?Category
     {
         return $this->category;
     }
@@ -155,7 +155,7 @@ public function getCategory()
      *
      * @return $this
      */
-    public function setCategory(Category $category = null)
+    public function setCategory(Category $category = null): ?Category
     {
         $this->category = $category;
 
@@ -191,7 +191,7 @@ public function setName($name)
      *
      * @return string[]
      */
-    public function getPhotoUrls()
+    public function getPhotoUrls(): array
     {
         return $this->photoUrls;
     }
@@ -203,7 +203,7 @@ public function getPhotoUrls()
      *
      * @return $this
      */
-    public function setPhotoUrls(array $photoUrls)
+    public function setPhotoUrls(array $photoUrls): array
     {
         $this->photoUrls = $photoUrls;
 
@@ -215,7 +215,7 @@ public function setPhotoUrls(array $photoUrls)
      *
      * @return OpenAPI\Server\Model\Tag[]|null
      */
-    public function getTags()
+    public function getTags(): ?array
     {
         return $this->tags;
     }
@@ -227,7 +227,7 @@ public function getTags()
      *
      * @return $this
      */
-    public function setTags(array $tags = null)
+    public function setTags(array $tags = null): ?array
     {
         $this->tags = $tags;