This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Move bottom up fuser declaration to header file #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUILD
Outdated
| @@ -18,6 +18,7 @@ td_library( | |||
| "include/mlir-tcp/Dialect/IR/TcpEnums.td", | |||
| "include/mlir-tcp/Dialect/IR/TcpOps.td", | |||
| "include/mlir-tcp/Dialect/IR/TcpTypes.td", | |||
| "include/mlir-tcp/Dialect/IR/TcpOpsCruiseInternal.td", | |||
There was a problem hiding this comment.
Thanks for catching this. Fixed
BUILD
Outdated
Comment on lines
198
to
199
| "lib/Conversion/TorchToTcp/TorchToTcpCruiseInternal.cpp", | ||
| "lib/Conversion/TorchToTcp/CruiseInternalPatterns.cpp", |
added 2 commits
December 6, 2023 13:30
| std::function<void(Operation *, PatternRewriter &rewriter)>; | ||
|
|
||
| GenericBottomUpFuser(MLIRContext *context, CanFuseFuncType canFuseCallback, | ||
| PostProcessingFuncType postFuncCallback = nullptr) |
There was a problem hiding this comment.
Please add brief docstrings/comments on what the constructor args (canFuseCallback and postFuncCallback) are meant to do. Especially since the upstream passes (like TcpFuseElementwiseOpsPass) don't use the postFuncCallback, it is unclear from the source code in the header.
sjain-stanford
approved these changes
Dec 7, 2023
added 3 commits
December 7, 2023 09:33
srinathava
pushed a commit
to srinathava/mlir-tcp
that referenced
this pull request
Jun 24, 2024
Move bottom up fuser declaration to header file No testing required since it's a minor restructuring --------- Co-authored-by: Muhammad Abubakar <muhammad.abubakar@getcruise.com>
srinathava
pushed a commit
to srinathava/mlir-tcp
that referenced
this pull request
Jun 24, 2024
Add missing file from previous PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move bottom up fuser declaration to header file
No testing required since it's a minor restructuring