Fix incorrect has_changed result for AutoCompleteSelectField that has not been filled in. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2016 10:32
… by using a similar solution that `django.forms.models.ModelChoiceField.has_changed` uses.
|
thank you ! |
|
Cool, happy to help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for empty inlines incorrectly showing as "changed", thus preventing form submissions.
The solution proposed in this PR is very much the same as
ModelChoiceField.has_changed.As @crucialfelix mentioned in #142, it would be more correct for
AutoCompleteSelectFieldto rather inherit fromModelChoiceField, and probably by extension,AutoCompleteSelectMultipleFieldshould inherit fromModelMultipleChoiceField.Changing the fields' inheritance would have far-reaching consequences and will take longer to implement, so this PR only deals with the immediate issue, not the correctness of the class inheritance.