Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Spring's @Cacheable annotation instead of manaul caching in Defau… #92

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

agrancaric
Copy link
Collaborator

…ltTransientPropertyResolverService

Basic information

  • nrich version:
    1.2.1
  • Module:
    nrich-webmvc

Additional information

Description

Summary

Removed custom caching in DefaultTransientPropertyResolverService and used @Cacheable annotation instead.

Details

Removed custom caching in DefaultTransientPropertyResolverService and used @Cacheable annotation instead.

Related issue

#74

Types of changes

  • Refactoring

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric self-assigned this Apr 13, 2022
@agrancaric agrancaric linked an issue Apr 13, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #92 (d263923) into master (1ee4ab6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
- Coverage     96.13%   96.12%   -0.01%     
+ Complexity     1016     1015       -1     
============================================
  Files           151      151              
  Lines          2431     2428       -3     
  Branches        223      223              
============================================
- Hits           2337     2334       -3     
  Misses           34       34              
  Partials         60       60              
Impacted Files Coverage Δ
...rvice/DefaultTransientPropertyResolverService.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee4ab6...d263923. Read the comment docs.

@jsajlovic jsajlovic added this to the v1.4.0 milestone Apr 13, 2022
@jsajlovic jsajlovic modified the milestones: v1.4.0, v1.3.0 Apr 14, 2022
@agrancaric agrancaric force-pushed the feature_useCacheableInsteadOfManualCache branch from a3b8d3c to d263923 Compare April 14, 2022 15:44
@jsajlovic jsajlovic merged commit d66dfbb into master Apr 14, 2022
@jsajlovic jsajlovic deleted the feature_useCacheableInsteadOfManualCache branch April 14, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change DefaultTransientPropertyResolverService to use @Cacheable
3 participants