Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature support range queries in string search #91

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.2.1
  • Module:
    nrich-registry, nrich-search

Additional information

Description

Summary

Added support for range queries in JpaStringSearchExecutor (i.e. dateFrom, dateTo etc)

Details

Added support for range queries in JpaStringSearchExecutor (i.e. dateFrom, dateTo etc)

Related issue

#81

Types of changes

  • Enhancement (non-breaking change which enhances existing functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric self-assigned this Apr 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #91 (8b60ada) into master (7378b33) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master      #91   +/-   ##
=========================================
  Coverage     96.12%   96.13%           
- Complexity     1015     1017    +2     
=========================================
  Files           151      152    +1     
  Lines          2426     2432    +6     
  Branches        223      224    +1     
=========================================
+ Hits           2332     2338    +6     
  Misses           34       34           
  Partials         60       60           
Impacted Files Coverage Δ
...istry/data/service/DefaultRegistryDataService.java 94.73% <100.00%> (+0.19%) ⬆️
...ter/DefaultStringToEntityPropertyMapConverter.java 100.00% <100.00%> (ø)
...net/croz/nrich/search/parser/SearchDataParser.java 92.17% <100.00%> (-0.51%) ⬇️
...ich/search/repository/JpaStringSearchExecutor.java 100.00% <100.00%> (ø)
...a/net/croz/nrich/search/util/PropertyNameUtil.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7378b33...8b60ada. Read the comment docs.

@agrancaric agrancaric linked an issue Apr 12, 2022 that may be closed by this pull request
@jsajlovic jsajlovic added this to the v1.4.0 milestone Apr 12, 2022
@agrancaric agrancaric force-pushed the feature_supportRangeQueriesInStringSearch branch from 8b60ada to 4d34ed1 Compare April 14, 2022 10:11
@agrancaric agrancaric force-pushed the feature_supportRangeQueriesInStringSearch branch from 4d34ed1 to 6780c78 Compare April 14, 2022 16:42
@agrancaric agrancaric requested a review from jsajlovic April 14, 2022 16:43
@jsajlovic jsajlovic modified the milestones: v1.4.0, v1.3.0 Apr 14, 2022
@agrancaric agrancaric force-pushed the feature_supportRangeQueriesInStringSearch branch from 6780c78 to 81af30a Compare April 14, 2022 17:49
@agrancaric agrancaric force-pushed the feature_supportRangeQueriesInStringSearch branch from 81af30a to 2c89a5e Compare April 14, 2022 17:50
@jsajlovic jsajlovic merged commit 59efdec into master Apr 14, 2022
@jsajlovic jsajlovic deleted the feature_supportRangeQueriesInStringSearch branch April 14, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support range queries in string search
3 participants