Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature serialize javascript type as lowercase #88

Merged
merged 5 commits into from
Apr 12, 2022

Conversation

agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.2.1
  • Module:
    nrich-registry

Additional information

Description

Summary

Changed serialization of JavascriptType enum to be lowercase.

Details

Changed serialization of JavascriptType enum to be lowercase.

Related issue

#73

Types of changes

  • Enhancement (non-breaking change which enhances existing functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric self-assigned this Apr 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #88 (1415074) into master (5336699) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
+ Coverage     96.08%   96.12%   +0.04%     
- Complexity     1014     1015       +1     
============================================
  Files           151      151              
  Lines          2425     2426       +1     
  Branches        223      223              
============================================
+ Hits           2330     2332       +2     
+ Misses           35       34       -1     
  Partials         60       60              
Impacted Files Coverage Δ
...i/configuration/model/property/JavascriptType.java 100.00% <100.00%> (+33.33%) ⬆️
.../configuration/NrichRegistryAutoConfiguration.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5336699...1415074. Read the comment docs.

@jsajlovic jsajlovic linked an issue Apr 12, 2022 that may be closed by this pull request
Copy link
Contributor

@jsajlovic jsajlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do a rebase onto master as well.

@agrancaric agrancaric force-pushed the feature_serializeJavascriptTypeAsLowercase branch from 9ba7a54 to 606963f Compare April 12, 2022 08:35
@agrancaric agrancaric force-pushed the feature_serializeJavascriptTypeAsLowercase branch from 606963f to 1415074 Compare April 12, 2022 08:35
@agrancaric agrancaric requested a review from jsajlovic April 12, 2022 08:35
@jsajlovic jsajlovic merged commit 7378b33 into master Apr 12, 2022
@jsajlovic jsajlovic deleted the feature_serializeJavascriptTypeAsLowercase branch April 12, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change javascriptType property values to lowercase
3 participants