Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature change resolving of form and column display values #84

Merged
merged 3 commits into from
Apr 11, 2022

Conversation

agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.2.1
  • Module:
    nrich-registry

Additional information

Description

Summary

Changed default display values for formLabel and columnHeader now they use capitalised and space separated attribute name i.e. (carId will be Car id) so the need for overriding of display values can be reduced.

Details

Changed default display values for formLabel and columnHeader now they use capitalised and space separated attribute name i.e. (carId will be Car id) so the need for overriding of display values can be reduced.

Related issue

#72

Types of changes

  • Enhancement (non-breaking change which enhances existing functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric self-assigned this Apr 8, 2022
@agrancaric agrancaric linked an issue Apr 8, 2022 that may be closed by this pull request
Copy link
Contributor

@jsajlovic jsajlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We just need a rebase onto master.

@agrancaric agrancaric force-pushed the feature_changeResolvingOfFormAndColumnDisplayValues branch from c180911 to 1e188bf Compare April 11, 2022 20:00
@jsajlovic jsajlovic merged commit f1b987f into master Apr 11, 2022
@jsajlovic jsajlovic deleted the feature_changeResolvingOfFormAndColumnDisplayValues branch April 11, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capitalize values for formLabel and columnHeader
2 participants