Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature refactor controller tests #83

Merged
merged 4 commits into from
Apr 11, 2022
Merged

Conversation

agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.2.1
  • Module:
    Project

Additional information

Description

Summary

Refactored controller and interceptor tests to use standard MockMvc matchers, extracted common methods in BaseControllerTest or *GeneratingUtil classes.

Details

Refactored controller and interceptor tests to use standard MockMvc matchers, extracted common methods in BaseControllerTest or *GeneratingUtil classes.

Related issue

Types of changes

  • Refactoring

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

…kMvc matchers and extract frequently used methods in the BaseControllerTest class
…le to use standar MockMvc matchers and extract frequently used methods in the CsrfInterceptorGeneratingUtil class
…vc matchers, extract frequently used methods in the BaseControllerTest class and refactor urls to use kebab case
@agrancaric agrancaric force-pushed the feature_refactorControllerTests branch from 0762ed2 to c01815a Compare April 11, 2022 13:22
Copy link
Contributor

@jsajlovic jsajlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jsajlovic jsajlovic merged commit 8fe2692 into master Apr 11, 2022
@jsajlovic jsajlovic deleted the feature_refactorControllerTests branch April 11, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants