Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature easier initialisation of flat data for excel report #62

Merged

Conversation

agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.2.1
  • Module:
    nrich-excel

Additional information

Description

It would be good for users to be able to just specify flat data for excel without need for MultiRowDataProvider.

Summary

Add static methods for creating builders for CreateExcelReportRequest, one for flat data and another for MultiRowDataProvider.

Details

Add static methods for creating builders for CreateExcelReportRequest, one for flat data and another for MultiRowDataProvider.

Related issue

#30

Types of changes

  • Breaking change (fix, enhancement or feature that would cause existing functionality to change in backward-incompatible way)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric self-assigned this Mar 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #62 (286adad) into master (0bae548) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master      #62   +/-   ##
=========================================
  Coverage     95.84%   95.84%           
- Complexity      998     1002    +4     
=========================================
  Files           147      148    +1     
  Lines          2405     2408    +3     
  Branches        224      224           
=========================================
+ Hits           2305     2308    +3     
  Misses           39       39           
  Partials         61       61           
Impacted Files Coverage Δ
...ch/excel/api/request/CreateExcelReportRequest.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bae548...286adad. Read the comment docs.

@agrancaric agrancaric force-pushed the feature_easierInitializationOfFlatDataForExcelReport branch from 5515c6b to 286adad Compare March 28, 2022 07:21
@agrancaric agrancaric requested a review from jsajlovic March 28, 2022 07:23
@agrancaric agrancaric force-pushed the feature_easierInitializationOfFlatDataForExcelReport branch from 286adad to c330555 Compare March 28, 2022 07:35
@jsajlovic jsajlovic merged commit b3be676 into master Mar 28, 2022
@jsajlovic jsajlovic deleted the feature_easierInitializationOfFlatDataForExcelReport branch March 28, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default implementation of MultiRowDataProvider in nrich-excel that supports flat data
3 participants