-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature add form configuration mapping to configuration properties #61
Merged
jsajlovic
merged 4 commits into
master
from
feature_addFormConfigurationMappingToConfigurationProperties
Mar 28, 2022
Merged
Feature add form configuration mapping to configuration properties #61
jsajlovic
merged 4 commits into
master
from
feature_addFormConfigurationMappingToConfigurationProperties
Mar 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31fa1ee
to
8cf02f9
Compare
4fc3721
to
37027a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=========================================
Coverage 95.84% 95.84%
Complexity 998 998
=========================================
Files 147 148 +1
Lines 2405 2407 +2
Branches 224 224
=========================================
+ Hits 2305 2307 +2
Misses 39 39
Partials 61 61
Continue to review full report at Codecov.
|
jsajlovic
suggested changes
Mar 27, 2022
.../net/croz/nrich/excel/starter/configuration/NrichFormConfigurationAutoConfigurationTest.java
Outdated
Show resolved
Hide resolved
...z/nrich/formconfiguration/starter/configuration/NrichFormConfigurationAutoConfiguration.java
Outdated
Show resolved
Hide resolved
.../croz/nrich/registry/data/customizer/RegistryDataFormConfigurationMappingCustomizerTest.java
Outdated
Show resolved
Hide resolved
37027a0
to
037087c
Compare
037087c
to
ea66546
Compare
jsajlovic
approved these changes
Mar 28, 2022
…starter @ConfigurationProperties, remove not needed bean
… in nrich-registry module
…mizing form configuration
ea66546
to
3c8afcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic information
1.2.1
nrich-form-configuration-spring-boot-starter
Additional information
Description
It would be good to have formConfigurationMapping defined in a properties file instead as a bean.
Summary
Add formConfigurationMapping to NrichFormConfigurationProperties remove not needed formConfigurationMapping bean.
Details
Add formConfigurationMapping to NrichFormConfigurationProperties remove not needed formConfigurationMapping bean.
Related issue
#33
Types of changes
Checklist
I have updated the documentation accordingly(will be updated when this branch is merged since the documentation is in another branch)