Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature add form configuration mapping to configuration properties #61

Merged

Conversation

agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.2.1
  • Module:
    nrich-form-configuration-spring-boot-starter

Additional information

Description

It would be good to have formConfigurationMapping defined in a properties file instead as a bean.

Summary

Add formConfigurationMapping to NrichFormConfigurationProperties remove not needed formConfigurationMapping bean.

Details

Add formConfigurationMapping to NrichFormConfigurationProperties remove not needed formConfigurationMapping bean.

Related issue

#33

Types of changes

  • Breaking change (fix, enhancement or feature that would cause existing functionality to change in backward-incompatible way)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly (will be updated when this branch is merged since the documentation is in another branch)
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric self-assigned this Mar 21, 2022
@agrancaric agrancaric linked an issue Mar 21, 2022 that may be closed by this pull request
@agrancaric agrancaric force-pushed the feature_addFormConfigurationMappingToConfigurationProperties branch from 31fa1ee to 8cf02f9 Compare March 25, 2022 09:49
@agrancaric agrancaric marked this pull request as draft March 25, 2022 10:05
@agrancaric agrancaric marked this pull request as ready for review March 26, 2022 12:37
@agrancaric agrancaric force-pushed the feature_addFormConfigurationMappingToConfigurationProperties branch from 4fc3721 to 37027a0 Compare March 26, 2022 12:38
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2022

Codecov Report

Merging #61 (037087c) into master (0bae548) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master      #61   +/-   ##
=========================================
  Coverage     95.84%   95.84%           
  Complexity      998      998           
=========================================
  Files           147      148    +1     
  Lines          2405     2407    +2     
  Branches        224      224           
=========================================
+ Hits           2305     2307    +2     
  Misses           39       39           
  Partials         61       61           
Impacted Files Coverage Δ
...i/util/FormConfigurationMappingCustomizerUtil.java 100.00% <100.00%> (ø)
...ation/NrichFormConfigurationAutoConfiguration.java 100.00% <100.00%> (ø)
...r/properties/NrichFormConfigurationProperties.java 100.00% <100.00%> (ø)
.../configuration/NrichRegistryAutoConfiguration.java 100.00% <100.00%> (ø)
...egistryDataFormConfigurationMappingCustomizer.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bae548...037087c. Read the comment docs.

@agrancaric agrancaric force-pushed the feature_addFormConfigurationMappingToConfigurationProperties branch from 37027a0 to 037087c Compare March 28, 2022 07:16
@agrancaric agrancaric requested a review from jsajlovic March 28, 2022 07:24
@agrancaric agrancaric force-pushed the feature_addFormConfigurationMappingToConfigurationProperties branch from 037087c to ea66546 Compare March 28, 2022 07:32
@agrancaric agrancaric force-pushed the feature_addFormConfigurationMappingToConfigurationProperties branch from ea66546 to 3c8afcb Compare March 28, 2022 07:44
@jsajlovic jsajlovic merged commit 6a5d3ed into master Mar 28, 2022
@jsajlovic jsajlovic deleted the feature_addFormConfigurationMappingToConfigurationProperties branch March 28, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support defining mapping between formId and class through properties
3 participants