Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature rename spring util module #60

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Conversation

agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.2.1
  • Module:
    nrich-spring-util

Additional information

Description

Rename nrich-spring-util to nrich-spring to better match other module names.

Summary

Renamed nrich-spring-util module to nrich-spring.

Details

Renamed nrich-spring-util module to nrich-spring.

Related issue

#46

Types of changes

  • Breaking change (fix, enhancement or feature that would cause existing functionality to change in backward-incompatible way)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric self-assigned this Mar 21, 2022
@agrancaric agrancaric linked an issue Mar 21, 2022 that may be closed by this pull request
Copy link
Contributor

@jsajlovic jsajlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename nrich-spring-util to nrich-spring in:

  1. README.MD line 85
  2. nrich-spring\README.MD line 1
  3. nrich-spring\README.MD line 3, in 2 places

@agrancaric agrancaric force-pushed the feature_renameSpringUtilModule branch from 25e9b9c to 320b1a9 Compare March 28, 2022 07:23
@agrancaric agrancaric requested a review from jsajlovic March 28, 2022 07:23
@codecov-commenter
Copy link

Codecov Report

Merging #60 (320b1a9) into master (0bae548) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #60   +/-   ##
=========================================
  Coverage     95.84%   95.84%           
  Complexity      998      998           
=========================================
  Files           147      147           
  Lines          2405     2405           
  Branches        224      224           
=========================================
  Hits           2305     2305           
  Misses           39       39           
  Partials         61       61           
Impacted Files Coverage Δ
...oz/nrich/spring/util/ApplicationContextHolder.java 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bae548...320b1a9. Read the comment docs.

@jsajlovic jsajlovic merged commit bfe6c31 into master Mar 28, 2022
@jsajlovic jsajlovic deleted the feature_renameSpringUtilModule branch March 28, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename nrich-spring-util module to nrich-spring
3 participants