Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature add module descriptions #48

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Conversation

agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.2.1
  • Module:
    Project

Additional information

Description

All our modules have same description it would be better for each to have different description.

Summary

Added description to each module, changed publishing to include that description.

Details

Added description to each module, changed publishing to include that description.

Related issue

#47

Types of changes

  • Enhancement (non-breaking change which enhances existing functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric self-assigned this Mar 17, 2022
@agrancaric agrancaric force-pushed the feature_addModuleDescriptions branch from 70a89f6 to 7ebf027 Compare March 17, 2022 11:33
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #48 (4590bb0) into master (4180253) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #48      +/-   ##
============================================
- Coverage     95.80%   95.77%   -0.03%     
- Complexity      987      993       +6     
============================================
  Files           145      145              
  Lines          2384     2391       +7     
  Branches        222      222              
============================================
+ Hits           2284     2290       +6     
- Misses           38       39       +1     
  Partials         62       62              
Impacted Files Coverage Δ
...csrf/configuration/NrichCsrfAutoConfiguration.java 82.35% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4180253...4590bb0. Read the comment docs.

@agrancaric agrancaric force-pushed the feature_addModuleDescriptions branch from 7ebf027 to 4590bb0 Compare March 18, 2022 07:34
@jsajlovic jsajlovic force-pushed the feature_addModuleDescriptions branch from 4590bb0 to ca65a9e Compare March 18, 2022 08:20
@jsajlovic jsajlovic merged commit 24670c2 into master Mar 18, 2022
@jsajlovic jsajlovic deleted the feature_addModuleDescriptions branch March 18, 2022 08:29
@agrancaric agrancaric linked an issue Mar 18, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add POM description for every submodule
3 participants