Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature support customising path in controllers #43

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.2.1
  • Module:
    nrich-form-configuration, nrich-registry, nrich-security-csrf

Additional information

Description

It would be useful to allow customising path (RequestMapping) in all controllers.

Summary

Add support for customising path, changed the previous implementation in nrich-registry to allow for specifying full path.

Details

Add support for customising path, changed the previous implementation in nrich-registry to allow for specifying full path.

Related issue

#38

Types of changes

  • Breaking change (fix, enhancement or feature that would cause existing functionality to change in backward-incompatible way)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly (documentation is not yet merged so currently it is not done)
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric self-assigned this Mar 16, 2022
@agrancaric agrancaric linked an issue Mar 16, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #43 (ea7fea4) into master (4180253) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #43   +/-   ##
=========================================
  Coverage     95.80%   95.80%           
  Complexity      987      987           
=========================================
  Files           145      145           
  Lines          2384     2384           
  Branches        222      222           
=========================================
  Hits           2284     2284           
  Misses           38       38           
  Partials         62       62           
Impacted Files Coverage Δ
...ration/controller/FormConfigurationController.java 100.00% <ø> (ø)
...on/controller/RegistryConfigurationController.java 100.00% <ø> (ø)
...gistry/data/controller/RegistryDataController.java 100.00% <ø> (ø)
.../history/controller/RegistryHistoryController.java 100.00% <ø> (ø)
...csrf/configuration/NrichCsrfAutoConfiguration.java 80.00% <ø> (ø)
...urity/csrf/core/controller/CsrfPingController.java 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4180253...ea7fea4. Read the comment docs.

Copy link
Contributor

@jsajlovic jsajlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jsajlovic jsajlovic merged commit 5ca4e3e into master Mar 17, 2022
@jsajlovic jsajlovic deleted the feature_supportCustomisingPathInControllers branch March 17, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for customising path in all controllers
3 participants