Add missing conditional on bean #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=========================================
Coverage 95.72% 95.72%
Complexity 985 985
=========================================
Files 145 145
Lines 2384 2384
Branches 222 222
=========================================
Hits 2282 2282
Misses 40 40
Partials 62 62
Continue to review full report at Codecov.
|
…iguration-spring-boot-starter module
…csrf-spring-boot-starter module
…ring-boot-starter module
…spring-boot-starter module and restrict conditional for controllers to servlet environment
d7877c0 to
cd7581f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic information
1.2.1
Project
Additional information
Description
Some *AutoConfiguration classes are missing @ConditionalOnMissingBean annotations on some beans. Add where missing and appropriate.
Summary
Added @ConditionalOnMissingBean on beans where it was missing, add servlet restriction to registry controllers @ConditionalOnWebApplication annotation.
Details
Added @ConditionalOnMissingBean on beans where it was missing, add servlet restriction to registry controllers @ConditionalOnWebApplication annotation.
Related issue
#34
Types of changes
Checklist
My change requires a change to the documentationI have updated the documentation accordinglyI have added tests to cover my changes