Feature support join by custom id name

[agrancaric]

Basic information

• nrich version:
  1.4.2
• Module:
  nrich-search

Additional information

Description

Summary

Currently, only joining by a property named id is supported when using a subquery. We are adding support for joining by any property annotated with @Id annotation.

Details

Currently, only joining by a property named id is supported when using a subquery. There are cases when we have a property with a different name representing the identity column. Because of that, we are adding support for joining by any property annotated with @Id annotation.

Related issue

Types of changes

• Enhancement (non-breaking change which enhances existing functionality)

Checklist

• I have read the project's CONTRIBUTING document
• I have checked my code with the project's static analysis tooling
• I have formatted my code with the project's IDEA code-style configuration
• I have checked my code for misspellings
• I have organized my changes in easy-to-follow commits
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have added tests to cover my changes
• All new and existing tests pass.

[codecov]

Codecov Report

Base: 96.64% // Head: 96.64% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f711e6e) compared to base (09a56e0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #133   +/-   ##
=========================================
  Coverage     96.64%   96.64%           
  Complexity     1075     1075           
=========================================
  Files           157      156    -1     
  Lines          2532     2534    +2     
  Branches        233      233           
=========================================
+ Hits           2447     2449    +2     
  Misses           32       32           
  Partials         53       53           

Impacted Files	Coverage Δ
...net/croz/nrich/search/support/JpaQueryBuilder.java	96.64% <100.00%> (+0.06%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.