Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature improvements for native image run #130

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.4.1
  • Module:
    project

Additional information

Description

Summary

Make required changes to enable easier native image running.

Details

Add parameters to compile java task to be able to use @ConfigurationProperties classes, use Validator interface instead of an implementation.

Related issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which enhances existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix, enhancement or feature that would cause existing functionality to change in backward-incompatible way)
  • Docs change
  • Refactoring
  • Dependency upgrade

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric self-assigned this Sep 2, 2022
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Base: 96.64% // Head: 96.64% // No change to project coverage 👍

Coverage data is based on head (9eeb2d4) compared to base (b7216ca).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #130   +/-   ##
=========================================
  Coverage     96.64%   96.64%           
  Complexity     1070     1070           
=========================================
  Files           157      157           
  Lines          2530     2530           
  Branches        232      232           
=========================================
  Hits           2445     2445           
  Misses           32       32           
  Partials         53       53           
Impacted Files Coverage Δ
...ation/NrichFormConfigurationAutoConfiguration.java 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jtomic-croz jtomic-croz merged commit 43f12a6 into master Sep 2, 2022
@jtomic-croz jtomic-croz deleted the feature_improvementsForNativeImageRun branch September 2, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants