Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SearchExecutorJpaRepositoryFactoryBean initialization #118

Merged

Conversation

agrancaric
Copy link
Collaborator

@agrancaric agrancaric commented Jul 9, 2022

Basic information

  • nrich version:
    1.4.0
  • Module:
    nrich-search

Additional information

Description

Summary

Refactored SearchExecutorJpaRepositoryFactoryBean initialization by moving constructor dependency resolving to afterPropertiesSet method.

Details

Refactored SearchExecutorJpaRepositoryFactoryBean initialization by moving constructor dependency resolving to afterPropertiesSet method since the former fails when there are getBean calls before initialization is complete.

Related issue

#117

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric requested review from jsajlovic and jzrilic July 9, 2022 13:32
@agrancaric agrancaric self-assigned this Jul 9, 2022
…constructor dependency resolving to afterPropertiesSet method since the former fails when there are getBean calls before
@codecov
Copy link

codecov bot commented Jul 9, 2022

Codecov Report

Merging #118 (c4227d2) into master (c113348) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #118   +/-   ##
=========================================
  Coverage     96.62%   96.63%           
- Complexity     1052     1054    +2     
=========================================
  Files           155      155           
  Lines          2492     2497    +5     
  Branches        231      231           
=========================================
+ Hits           2408     2413    +5     
  Misses           31       31           
  Partials         53       53           
Impacted Files Coverage Δ
...actory/SearchExecutorJpaRepositoryFactoryBean.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c113348...c4227d2. Read the comment docs.

@agrancaric agrancaric force-pushed the bugfix_refactorSearchExecutorJpaRepositoryFactoryBean branch from f7fb666 to c4227d2 Compare July 9, 2022 13:36
@jzrilic jzrilic changed the title Refactor SearchExecutorJpaRepositoryFactoryBean initialization, move … Refactor SearchExecutorJpaRepositoryFactoryBean initialization Jul 13, 2022
@jzrilic jzrilic merged commit 2ffcbb0 into master Jul 13, 2022
@jzrilic jzrilic deleted the bugfix_refactorSearchExecutorJpaRepositoryFactoryBean branch July 13, 2022 12:27
@jzrilic jzrilic added this to the v1.4.1 milestone Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants