Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature support loading requests from request package #113

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.4.0
  • Module:
    nrich-registry

Additional information

Description

Summary

Added support for resolving of custom registry validation classes from request package.

Details

Added support for resolving of custom registry validation classes from request package.

Related issue

Types of changes

  • Enhancement (non-breaking change which enhances existing functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric requested review from ijakus, jsajlovic and jzrilic May 9, 2022 08:35
@agrancaric agrancaric self-assigned this May 9, 2022
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #113 (2ffcbb0) into master (2ffcbb0) will not change coverage.
The diff coverage is n/a.

❗ Current head 2ffcbb0 differs from pull request most recent head 0dc4113. Consider uploading reports for the commit 0dc4113 to get more accurate results

@@            Coverage Diff            @@
##             master     #113   +/-   ##
=========================================
  Coverage     96.63%   96.63%           
  Complexity     1054     1054           
=========================================
  Files           155      155           
  Lines          2497     2497           
  Branches        231      231           
=========================================
  Hits           2413     2413           
  Misses           31       31           
  Partials         53       53           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ffcbb0...0dc4113. Read the comment docs.

@agrancaric agrancaric force-pushed the feature_supportLoadingRequestsFromRequestPackage branch 3 times, most recently from 0922db0 to 81354ff Compare May 9, 2022 12:12
@agrancaric agrancaric force-pushed the feature_supportLoadingRequestsFromRequestPackage branch from 81354ff to b14141e Compare June 27, 2022 11:48
@agrancaric agrancaric force-pushed the feature_supportLoadingRequestsFromRequestPackage branch from b14141e to 133b775 Compare July 13, 2022 12:31
@agrancaric agrancaric force-pushed the feature_supportLoadingRequestsFromRequestPackage branch from 133b775 to 3b794ff Compare July 13, 2022 13:41
@agrancaric agrancaric requested a review from jzrilic July 13, 2022 13:41
@agrancaric agrancaric force-pushed the feature_supportLoadingRequestsFromRequestPackage branch 2 times, most recently from 804040c to d0dbb22 Compare July 13, 2022 14:10
@agrancaric agrancaric force-pushed the feature_supportLoadingRequestsFromRequestPackage branch from d0dbb22 to 0dc4113 Compare July 13, 2022 14:55
@agrancaric agrancaric requested a review from jzrilic July 13, 2022 15:03
@jzrilic jzrilic merged commit e83a640 into master Jul 14, 2022
@jzrilic jzrilic deleted the feature_supportLoadingRequestsFromRequestPackage branch July 14, 2022 08:13
@jzrilic jzrilic added this to the v1.4.1 milestone Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants