Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not needed condition (Java 8) from workflow since we're only b… #110

Merged
merged 1 commit into from
May 6, 2022

Conversation

agrancaric
Copy link
Collaborator

…uilding with Java 8

Basic information

  • nrich version:
    1.3.0
  • Module:
    Project

Additional information

Description

Summary

Removed not needed condition from workflow (to execute only on Java 8 since we're only building on Java 8)

Details

Removed not needed condition from workflow (to execute only on Java 8 since we're only building on Java 8)

Related issue

Types of changes

  • Refactoring

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric requested a review from jsajlovic May 5, 2022 06:30
@agrancaric agrancaric self-assigned this May 5, 2022
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #110 (ae6775b) into master (d52be62) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #110   +/-   ##
=========================================
  Coverage     96.17%   96.17%           
  Complexity     1028     1028           
=========================================
  Files           154      154           
  Lines          2460     2460           
  Branches        226      226           
=========================================
  Hits           2366     2366           
  Misses           35       35           
  Partials         59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52be62...ae6775b. Read the comment docs.

@jsajlovic jsajlovic added this to the v1.4.0 milestone May 5, 2022
Copy link
Contributor

@jsajlovic jsajlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do a rebase onto master, please.

@agrancaric agrancaric force-pushed the feature_removeNotNeededConditionFromWorkflow branch from 0bd67c0 to ae6775b Compare May 6, 2022 06:01
@jsajlovic jsajlovic merged commit eace7f4 into master May 6, 2022
@jsajlovic jsajlovic deleted the feature_removeNotNeededConditionFromWorkflow branch May 6, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants