Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature encryption improvements #109

Merged
merged 3 commits into from
May 6, 2022
Merged

Conversation

agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.3.0
  • Module:
    nrich-encrypt

Additional information

Description

Summary

Added support for encryption/decryption of arrays or objects, arrays of strings and collections of strings. Limited allowed collection types to Set and List and fixed issue with Sets not being created correctly.

Details

Added support for encryption/decryption of arrays or objects, arrays of strings and collections of strings. Limited allowed collection types to Set and List and fixed issue with Sets not being created correctly.

Related issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which enhances existing functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric requested review from ijakus, jsajlovic and jzrilic May 3, 2022 12:28
@agrancaric agrancaric self-assigned this May 3, 2022
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #109 (fbf29b2) into master (506aa54) will increase coverage by 0.00%.
The diff coverage is 96.15%.

@@            Coverage Diff            @@
##             master     #109   +/-   ##
=========================================
  Coverage     96.61%   96.62%           
- Complexity     1042     1050    +8     
=========================================
  Files           155      155           
  Lines          2479     2486    +7     
  Branches        228      231    +3     
=========================================
+ Hits           2395     2402    +7     
  Misses           31       31           
  Partials         53       53           
Impacted Files Coverage Δ
...ich/encrypt/service/DefaultDataEncryptService.java 96.55% <96.15%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506aa54...fbf29b2. Read the comment docs.

@jsajlovic jsajlovic added this to the v1.4.0 milestone May 5, 2022
@agrancaric agrancaric force-pushed the feature_encryptionImprovements branch 2 times, most recently from e2192c4 to 65ec9ba Compare May 6, 2022 07:42
@agrancaric agrancaric requested a review from jsajlovic May 6, 2022 07:42
jsajlovic
jsajlovic previously approved these changes May 6, 2022
@agrancaric agrancaric force-pushed the feature_encryptionImprovements branch from 65ec9ba to c9d6afb Compare May 6, 2022 09:30
@agrancaric agrancaric force-pushed the feature_encryptionImprovements branch from c9d6afb to fbf29b2 Compare May 6, 2022 09:39
@agrancaric agrancaric requested a review from jsajlovic May 6, 2022 09:42
@jsajlovic jsajlovic merged commit 2a39f43 into master May 6, 2022
@jsajlovic jsajlovic deleted the feature_encryptionImprovements branch May 6, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants