Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor checkboxes and instructions in Pull Request template #10

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

jsajlovic
Copy link
Contributor

Basic information

  • nrich version: v1.1.1
  • Module: project

Description

Summary

Updated PR template and instructions.

Details

Replaced checkboxes with points in "Types of changes" and polished instructions, in order to have a cleaner process in regards to the "n of m tasks" GitHub PR display feature.

Types of changes

  • Enhancement (non-breaking change which enhances existing functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation (out of scope, just a PR template update)
  • I have updated the documentation accordingly (out of scope, just a PR template update)
  • I have added tests to cover my changes (out of scope, just a PR template update)
  • All new and existing tests pass.

@jsajlovic jsajlovic self-assigned this Feb 1, 2022
@jsajlovic jsajlovic merged commit e2c0bf0 into master Feb 4, 2022
@jsajlovic jsajlovic deleted the feature_pullRequestTemplateImprovements branch February 4, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants