-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open source setup #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to fulfil Central Repository requirements
In tests, for latest Windows version
In order to avoid warnings/errors on Windows, for instance, which mostly defaults to Cp1252
Consequently resolve javadocJar task warnings
128c06d
to
1e451b1
Compare
agrancaric
requested changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor issues.
nrich-excel/src/test/java/net/croz/nrich/excel/testutil/PoiDataResolverUtil.java
Outdated
Show resolved
Hide resolved
nrich-search-api/src/main/java/net/croz/nrich/search/api/request/SortablePageableRequest.java
Outdated
Show resolved
Hide resolved
...search-repository-api/src/main/java/net/croz/nrich/search/api/repository/SearchExecutor.java
Outdated
Show resolved
Hide resolved
3d86610
to
c7ff2ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.