feat(signals): Improve send signals process #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
julienloizelet
commented
Feb 23, 2024
- Use batch
- Use more precise SQL requests
…_machines_signals
rr404
requested changes
Feb 23, 2024
julienloizelet
added a commit
to julienloizelet/crowdsec-python-capi-sdk
that referenced
this pull request
Mar 14, 2024
* feat(sqlstorage): Add limit and offset arguments in get_all_signals function * feat(sqlstorage): Change delete_signals and delete_machines method to improve pruning * test(*): Add some test path to gitignore * feat(storage): Modify get_all_signals to have sent and is_failing param * feat(client): Add batch_size param for send_signals and prune_failing_machines_signals * feat(storage): Rename get_all_signals to get_signals * feat(log): Improve log messages * feat(signal): Return number of sent and pruned signal in related methods * test(*): Add test for get_signals * chore(changelog): Prepare release 0.4.0 * fix(send): Do not offset even if no prune as we are taking only not sent signals * feat(signals): Rename _send_signals to _send_signals_to_capi * style(*): Pass through lint * style(*): Pass through lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.