Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add add/edit tags to sort-tags-row components #2690

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

phroggster
Copy link
Collaborator

Description of the Change

  • Edits the tags popover menus to include add or add/edit tags menu options.
  • The padding and margin values look appropriate for me, but are open to be adjusted as desired.

Applicable Issues

#2188

Testing

Yes.

Screenshots

Screenshot of an empty component lacking tags, atop a separate screenshot of a component with several tags available (manually blurred out for screenshot purposes):
issue_2188

- Edits the tags popover menus to include add or add/edit tags menu
  options.
- The padding and margin values look appropriate for me, but are open to
  be adjusted if desired.
@phroggster phroggster requested a review from ebiggz as a code owner August 14, 2024 11:58
</div>
</script>
<div>
</div>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psst. This one's worth an extra comment. I thought I had messed something up when I looked at the diff, so now you get to read this text and waste ten seconds.

Copy link
Member

@ebiggz ebiggz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, thanks for adding it!

@ebiggz ebiggz merged commit 3c09985 into crowbartools:v5 Aug 14, 2024
1 check passed
@phroggster phroggster deleted the issue_2188 branch August 15, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants