fix: toggle connection effect (#2454) #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zunderscore
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
To fix the connection effect
the integration.id was missing from the id type
while I was here there was some linting issues so I resolved them
after fixing the id issue there was an issue where the
startup event would not wait for scripts to load
so I applied an await to the startupScriptsManager.runStartupScripts(); function and made the window event async.
Applicable Issues
#2454
Testing
loaded the application and looked in the log to ensure that the load event fired after all scripts where loaded
as well as saw the visual connection on the status area.
Screenshots