chore: username refactor #2432
Merged
chore: username refactor #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Refactors all uses of username to use the actual user login name instead of the display name, updates UI elements (mostly chat feed) to use the display name property for display purposes, deprecates
$useridname, and adds$userDisplayName.Applicable Issues
#2421
Testing
Verified basic bot functionality that depends on username, including chat messages, variables, events, channel rewards, roles
Verified chat feed display
Verified
$usernamestill functions properly in non-Unicode scenariosVerified new
$userDisplayNamevariable works as designed