Cleanup Secret and Lease objects from tfstate #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
2 tasks
ytsarev
requested changes
May 5, 2022
| _ = c.kube.List(ctx, ll, client.MatchingLabels(labels)) | ||
| for l := range ll.Items { | ||
| ls := ll.Items[l] | ||
| _ = c.kube.Delete(ctx, &ls) |
There was a problem hiding this comment.
We need to catch errors during this interaction with the kubernetes API
11:42:40 [ .. ] golangci-lint
internal/controller/workspace/workspace.go:331:2: Error return value of `c.kube.List` is not checked (errcheck)
_ = c.kube.List(ctx, sl, client.MatchingLabels(labels))
^
internal/controller/workspace/workspace.go:334:3: Error return value of `c.kube.Delete` is not checked (errcheck)
_ = c.kube.Delete(ctx, &sec)
^
internal/controller/workspace/workspace.go:337:2: Error return value of `c.kube.List` is not checked (errcheck)
_ = c.kube.List(ctx, ll, client.MatchingLabels(labels))
^
internal/controller/workspace/workspace.go:340:3: Error return value of `c.kube.Delete` is not checked (errcheck)
_ = c.kube.Delete(ctx, &ls)
^
11:42:49 [FAIL]
I've created #53 to enable automated check for that(slightly surprised that it was disabled :) )
Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
ytsarev
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bob Haddleton bob.haddleton@nokia.com
Description of your changes
Added code to the Delete method to clean up any Secret or Lease objects that were used by the Terraform
Kubernetes back end to store tfstate information.
Fixes #40
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested in an EKS deployment - verified that deleting a Workspace that is using a Kubernetes backend also deletes the associated Secret and Lease.