Enable terraform provider plugin cache #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes crossplane-contrib#122 Signed-off-by: Yury Tsarev <yury@upbound.io>
* Enable control over PluginCache functionality * Still enable it by default Signed-off-by: Yury Tsarev <yury@upbound.io>
Otherwise we have to reset provider pod to activate `pluginCache: false` Signed-off-by: Yury Tsarev <yury@upbound.io>
Signed-off-by: Yury Tsarev <yury@upbound.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Implement control over https://developer.hashicorp.com/terraform/cli/config/config-file#provider-plugin-cache and enable it by default.
ProviderConfig.Specis extended with the optionalpluginCachefield which is true by default.Fixes #122
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Creating a couple of Workspaces with aws provider dependency.
Directory sizes within the controller pod with
providerCache: false:It is visible that aws provider binary is fetched to both of workplaces
Directory sizes within the controller pod with
providerCache: true:It is visible that only
/tf/plugin-cachecontains the actual provider binary and the Workspace directories are becoming very lightweight.The workspaces are fine and operational