Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add categories to provider CRDs #121

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

ytsarev
Copy link
Collaborator

@ytsarev ytsarev commented Nov 1, 2022

Description of your changes

Include provider CRDs into the relevant API categories.

Fixes #114

Enables getting Workspaces in the output of kubectl get managed and kubectl get terraform

Similar changes to ProviderConfig and ProviderConfigUsage for getting into kubectl get provider and kubectl get terraform output

Signed-off-by: Yury Tsarev yury@upbound.io

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

k apply -f examples/workspace-remote.yaml
workspace.tf.crossplane.io/example-remote configured

k get managed
NAME                                        READY   SYNCED   AGE
workspace.tf.crossplane.io/example-remote           False    5m21s

k get terraform
NAME                                                                        AGE     CONFIG-NAME   RESOURCE-KIND   RESOURCE-NAME
providerconfigusage.tf.crossplane.io/44d34bbb-c4e0-49c9-a7ec-27e496ed75a9   5m29s   default       Workspace       example-remote

NAME                                        READY   SYNCED   AGE
workspace.tf.crossplane.io/example-remote           False    5m29s

NAME                                      AGE
providerconfig.tf.crossplane.io/default   14m


k get provider
NAME                                                                        AGE     CONFIG-NAME   RESOURCE-KIND   RESOURCE-NAME
providerconfigusage.tf.crossplane.io/44d34bbb-c4e0-49c9-a7ec-27e496ed75a9   5m38s   default       Workspace       example-remote

NAME                                      AGE
providerconfig.tf.crossplane.io/default   14m

Fixes crossplane-contrib#114

Signed-off-by: Yury Tsarev <yury@upbound.io>
@ytsarev ytsarev requested a review from bobh66 November 1, 2022 17:36
Copy link
Collaborator

@bobh66 bobh66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ytsarev ytsarev merged commit 26b6d77 into crossplane-contrib:master Nov 1, 2022
@ytsarev ytsarev deleted the workspace-to-managed branch November 1, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace resources are not listed with kubectl get managed
2 participants