This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Marking passwords field of aws_elasticache_user as sensitive #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Depends on crossplane/terrajet#100
This PR depends on the following one -> crossplane/terrajet#197
Until merge the dependent PR, a temporary replace command was added to go.mod:
https://github.com/sergenyalcin/provider-jet-aws/blob/ae8fb3a002c0e24f868d0d608fa365ef42d6da7e/go.mod#L26
This PR marks the passwords field of aws_elasticache_user as sensitive. Now, this field is not sensitive and the passwords are put to the spec directly. Because for []string and []*string types, there is not support as sensitive fields. The dependent PR will provide this support. After merging the dependent PR in terrajet, this PR can be merged.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Generation of the resource was successfully completed. The
PasswordsSecretRef
field was generated as*[]v1.SecretKeySelector
I created the following manifest: