let ansible-runner shut down gracefully on timeout #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dasha Komsa <komsa.darya@gmail.com>
93298b9 to
808976e
Compare
| } | ||
| // if it doesn't respond to the SIGINT within 10s, | ||
| // it's going to be forcefully shut down with SIGKILL | ||
| dc.WaitDelay = 10 * time.Second |
There was a problem hiding this comment.
Just curious if it makes sense to allow the value of WaitDelay configurable.
There was a problem hiding this comment.
I'd leave it non-configurable until someone comes up with a use-case or asks for it, just to keep the configuration from bloating. But that said, can totally add the flag - you're the boss :)
There was a problem hiding this comment.
That makes sense to me. Let's deliver it first, then see the feedback from community.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #297. Please see issue description and comments for details.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Use the same steps as #297. Exec into the provider-ansible pod and run
top. Watch ansible-playbook processes shut down at the timeout time (cause ansible-runner shuts down the main ansible-playbook process it spun up).