Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #![doc(html_root_url)] to all crates #649

Closed
wants to merge 1 commit into from
Closed

Add #![doc(html_root_url)] to all crates #649

wants to merge 1 commit into from

Conversation

a1phyr
Copy link

@a1phyr a1phyr commented Jan 24, 2021

It enables external crates' documentation to link to crossbeam's one.

@taiki-e
Copy link
Member

taiki-e commented Jan 25, 2021

html_root_url is not needed in most cases. And api-guidelines no longer recommends this. See rust-lang/api-guidelines#229 for more.

taiki-e
taiki-e reviewed Jan 31, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the linked issue, I don't think this will bring any benefits beyond the maintenance burden, so I'll close this. Thanks anyway @a1phyr!

@taiki-e taiki-e closed this Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a1phyr @taiki-e