Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run simple tests on windows and linux #851

Closed
wants to merge 5 commits into from
Closed

run simple tests on windows and linux #851

wants to merge 5 commits into from

Conversation

Emilgardis
Copy link
Member

@Emilgardis Emilgardis commented Jun 24, 2022 •
edited
Loading

solves parts of #610, depends on #852

@Emilgardis Emilgardis requested a review from a team as a code owner June 24, 2022 16:50
@Emilgardis Emilgardis added the no changelog A valid PR without changelog (no-changelog) label Jun 24, 2022
@Emilgardis
Copy link
Member Author

Emilgardis commented Jun 24, 2022 •
edited
Loading

interesting, this all works for me, here the run fails

I tested it wrong :D

@Emilgardis Emilgardis force-pushed the tests-multi-os branch 2 times, most recently from a6e594c to a91bcfe Compare June 24, 2022 17:17
@Emilgardis Emilgardis changed the title run simple tests on mac, windows and linux run simple tests on windows and linux Jun 24, 2022
Alexhuszagh
Alexhuszagh reviewed Jun 24, 2022
View reviewed changes
src/docker/shared.rs
@@ -339,29 +339,61 @@ pub(crate) fn docker_mount(
Ok(mount_volumes)
}

#[cfg(target_os = "windows")]
fn winpath(path: &Path, verbose: bool) -> Result<PathBuf> {
Copy link
Contributor

@Alexhuszagh Alexhuszagh Jun 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this was added to this PR by mistake?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, see the previous error in https://github.com/cross-rs/cross/runs/7045847730?check_suite_focus=true

@Emilgardis Emilgardis mentioned this pull request Jun 24, 2022
Closed
@Emilgardis
Copy link
Member Author

Emilgardis commented Jun 24, 2022 •
edited
Loading

on windows, getting

Sending build context to Docker daemon    170kB
Error response from daemon: unsupported os linux
Error: 
   0: when building custom image
   1: when pre-building
   2: `"C:\Program Files\Docker\docker.EXE" build --platform linux/amd64 --label 'org.cross-rs.for-cross-target=x86_64-unknown-linux-gnu' --label 'org.cross-rs.workspace_root=C:\Users\runneradmin\AppData\Local\Temp\tmp.AExM7t25b6\workspace' --tag cross-custom-workspace:x86_64-unknown-linux-gnu-9f829-pre-build --build-arg 'CROSS_CMD=apt-get update && apt-get install -y gcc' --build-arg 'CROSS_DEB_ARCH=amd64' --file 'C:\Users\runneradmin\AppData\Local\Temp\tmp.AExM7t25b6\workspace\target\x86_64-unknown-linux-gnu\Dockerfile.x86_64-unknown-linux-gnu-custom' .` failed with exit code: 1
Note: CROSS_CMD=apt-get update && apt-get install -y gcc
Error: Process completed with exit code 1.

Not sure how to enable it properly.

docker info on windows-latest

Client:
 Context:    default
 Debug Mode: false
 Plugins:
  app: Docker Application (Docker Inc., v0.8.0)
  cluster: Manage Mirantis Container Cloud clusters (Mirantis Inc., v1.9.0)
  compose: Docker Compose (Docker Inc., v2.6.0)
  registry: Manage Docker registries (Docker Inc., 0.1.0)
Server:
 Containers: 0
  Running: 0
  Paused: 0
  Stopped: 0
 Images: 5
 Server Version: 20.10.7
 Storage Driver: windowsfilter
  Windows: 
 Logging Driver: json-file
 Plugins:
  Volume: local
  Network: ics internal l2bridge l2tunnel nat null overlay private transparent
  Log: awslogs etwlogs fluentd gcplogs gelf json-file local logentries splunk syslog
 Swarm: inactive
 Default Isolation: process
 Kernel Version: 10.0 20348 (20348.1.amd64fre.fe_release.210507-1500)
 Operating System: Windows Server 2022 Datacenter Version 2009 (OS Build 20348.768)
 OSType: windows
 Architecture: x86_64
 CPUs: 2
 Total Memory: 7GiB
 Name: fv-az206-305
 ID: CDDS:ASBM:5ONG:H4Q7:JUSZ:Y7Y3:KOK5:NZAX:VKVQ:SOJQ:EBJB:3PQP
 Docker Root Dir: C:\ProgramData\docker
 Debug Mode: false
 Registry: https://index.docker.io/v1/
 Labels:
 Experimental: false
 Insecure Registries:
  127.0.0.0/8
 Live Restore Enabled: false

@Emilgardis
Copy link
Member Author

Emilgardis commented Jun 24, 2022 •
edited
Loading

this is impossible, see actions/runner-images#2216 and actions/runner-images#252

@Emilgardis Emilgardis closed this Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexhuszagh Alexhuszagh Alexhuszagh left review comments

Assignees
No one assigned
Labels
no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emilgardis @Alexhuszagh