Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert part of changes done in #443 due to file mount issues on windows #461

Closed
wants to merge 1 commit into from

Conversation

Emilgardis
Copy link
Member

@Emilgardis Emilgardis commented Sep 19, 2020

Without this, cross on windows with docker for windows errors on

cross build --target armv7-unknown-linux-gnueabihf
docker: Error response from daemon: Mount denied:
The source path "\working\dir:/C:\working\dir:Z"
too many colons.
See 'docker run --help'.

If we somehow fixed that error, we'd then get

cross build --target armv7-unknown-linux-gnueabihf
docker: Error response from daemon: the working directory 'C:\working\dir' is invalid, it needs to be an absolute path.
See 'docker run --help'.

this pr simply reverts the project structure changes done in #443 to try and resolve that.

I'm unclear if this functionality is needed for the build env volumes.

cc @reitermarkus

@reitermarkus
Copy link
Member

I think this will break volumes given as relative paths.

@Emilgardis
Copy link
Member Author

Emilgardis commented Aug 9, 2021

I want to get this added. I don't think relative paths are important for this feature.

Correction: relative paths like ./path I think are important, but not ../path. As such, some logic should probably be available to consumers to mount paths within ../**/path to docker /path

@Emilgardis
Copy link
Member Author

Emilgardis commented Feb 6, 2022

To get this fixed, I've been thinking of instead having it mount like this, it should be configurable.
This also brings an added previous benefit of not leaking the path the user used to build, i.e leaking usernames etc.

@Emilgardis
Copy link
Member Author

closing in favor of new pr #665

@Emilgardis Emilgardis closed this Mar 17, 2022
@Emilgardis Emilgardis deleted the fix-windows branch April 6, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants