-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Linux kernel versions from 5.x to 6.x for certain targets. #1095
Conversation
bors try --target sparc64-unknown-linux-gnu powerpc64-unknown-linux-gnu riscv64-unknown-linux-gnu |
…-gnu riscv64-unknown-linux-gnu
this changelog entry should probably be applied to #591 as well |
tryBuild succeeded: |
1a886cc
to
339e8ee
Compare
.changes/1095.json
Outdated
@@ -0,0 +1,6 @@ | |||
{ | |||
"type": "fixed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed it so this used a fixed entry while the other uses a changed entry, so this makes it clear that this is a bug fix, and the other is a part of the image upgrade.
.changes/591.json
Outdated
}, | ||
{ | ||
"type": "changed", | ||
"description": "change powerpc64, riscv64, and sparc64 *-linux-gnu images to use a 6.x kernel instead of a 5.x kernel.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they went from 4* to 5* in this bump, no?
so shouldn't this be
change powerpc64, riscv64, and sparc64 *-linux-gnu images to use a 6.x kernel instead of a 4.x kernel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, the changelog file should probably be renamed to 591-1095.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I've consolidated the two and changed the changelog to be something like:
[
{
"type": "changed",
"description": "upgraded most linux images to use a 5.x kernel instead of a 4.x kernel.",
"breaking": true
}
{
"type": "changed",
"description": "updated powerpc64, riscv64, and sparc64 *-linux-gnu images to use a 6.x kernel instead of a 4.x kernel.",
"breaking": true,
"issues": [1094]
}
]
339e8ee
to
d18a025
Compare
d18a025
to
96531d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
If you really need kernel version 5 for these targets, consider using an older version of the image found on for example https://github.com/cross-rs/cross/pkgs/container/s390x-unknown-linux-gnu/versions
Build succeeded: |
Closes #1094.