Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use qualified Docker image names #571

Closed
link2xt opened this issue Jul 14, 2021 · 2 comments · Fixed by #609
Closed

Use qualified Docker image names #571

link2xt opened this issue Jul 14, 2021 · 2 comments · Fixed by #609

Comments

@link2xt
Copy link

link2xt commented Jul 14, 2021

Currently unqualified rustembedded/* image names are used instead of docker.io/rustembedded/*, so I have to add

unqualified-search-registries = ["docker.io"]

to /etc/containers/registries.conf.

I am using podman, which has no default registries and discourages using unqualified names.

@ryankurte
Copy link

sorta related, when we have qualified names it'd be neat to also push the containers to ghcr.io to improve the fetch speed with actions (dockerhub is slow and the new API limits are, rough)

Mstrodl added a commit to Mstrodl/cross that referenced this issue Jan 5, 2022
@Emilgardis Emilgardis linked a pull request Jan 24, 2022 that will close this issue
9 tasks
bors bot added a commit that referenced this issue Mar 13, 2022
609: switch to GHCR and use more github actions r=reitermarkus a=Emilgardis

addresses #607 #571

## what this does

- [x] change default registry to look for cross images to `ghcr.io`
- [x] move from azure CI for docker images to GHA
- [x] add clippy (that does not fail job, can be made to do this later) and rustfmt
- [x] bump QEMU to 5.1
- [ ] Add (better) layer caching

## Some nice things to have/include
- [x] Cache docker images, possibly using buildx (probably out of scope of this pr)
- [x] Use actions/cache
- [ ] make configuration easier to maintain
- [ ] possibly replace docker setup with actions

Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
Co-authored-by: Marco A L Barbosa <malbarbo@gmail.com>
Co-authored-by: Jesse Szwedko <jesse@szwedko.me>
Co-authored-by: Will <will@glozer.net>
Co-authored-by: Sven-Hendrik Haase <svenstaro@gmail.com>
Co-authored-by: Joe Richey <joerichey@google.com>
Co-authored-by: Markus Reiter <me@reitermark.us>
bors bot added a commit that referenced this issue Mar 13, 2022
609: switch to GHCR and use more github actions r=reitermarkus a=Emilgardis

addresses #607 #571

## what this does

- [x] change default registry to look for cross images to `ghcr.io`
- [x] move from azure CI for docker images to GHA
- [x] add clippy (that does not fail job, can be made to do this later) and rustfmt
- [x] bump QEMU to 5.1
- [ ] Add (better) layer caching

## Some nice things to have/include
- [x] Cache docker images, possibly using buildx (probably out of scope of this pr)
- [x] Use actions/cache
- [ ] make configuration easier to maintain
- [ ] possibly replace docker setup with actions

Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
Co-authored-by: Marco A L Barbosa <malbarbo@gmail.com>
Co-authored-by: Jesse Szwedko <jesse@szwedko.me>
Co-authored-by: Will <will@glozer.net>
Co-authored-by: Sven-Hendrik Haase <svenstaro@gmail.com>
Co-authored-by: Joe Richey <joerichey@google.com>
Co-authored-by: Markus Reiter <me@reitermark.us>
bors bot added a commit that referenced this issue Mar 13, 2022
609: switch to GHCR and use more github actions r=reitermarkus a=Emilgardis

addresses #607 #571

## what this does

- [x] change default registry to look for cross images to `ghcr.io`
- [x] move from azure CI for docker images to GHA
- [x] add clippy (that does not fail job, can be made to do this later) and rustfmt
- [x] bump QEMU to 5.1
- [ ] Add (better) layer caching

## Some nice things to have/include
- [x] Cache docker images, possibly using buildx (probably out of scope of this pr)
- [x] Use actions/cache
- [ ] make configuration easier to maintain
- [ ] possibly replace docker setup with actions

Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
Co-authored-by: Marco A L Barbosa <malbarbo@gmail.com>
Co-authored-by: Jesse Szwedko <jesse@szwedko.me>
Co-authored-by: Will <will@glozer.net>
Co-authored-by: Sven-Hendrik Haase <svenstaro@gmail.com>
Co-authored-by: Joe Richey <joerichey@google.com>
Co-authored-by: Markus Reiter <me@reitermark.us>
@bors bors bot closed this as completed in #609 Mar 14, 2022
@Emilgardis
Copy link
Member

Emilgardis commented Mar 14, 2022

The images are now (to-be) hosted on ghcr.io/cross-rs/{target}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants