Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert a non null pointer, nothing else #47

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

a4z
Copy link
Contributor

@a4z a4z commented Jul 29, 2021

As discussed in #30, the magic number brought since some time some
problems for some people.
Please find the details in the discussion of #30, and why we switch to
this assert now.

Fixes #30, second version.

As discussed in cross-language-cpp#30, the magic number brought since some time some
problems for some people.
Please find the details in the discussion of cross-language-cpp#30, and why we switch to
this assert now.

Fixes cross-language-cpp#30, second version.
@a4z a4z requested review from freitass, artwyman and jothepro July 29, 2021 17:05
Copy link
Contributor

@jothepro jothepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with that. 👍

@a4z a4z merged commit 485b4aa into cross-language-cpp:main Aug 1, 2021
Copy link

@artwyman artwyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was traveling when the review came through, but this looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assertion failure on Android AVD on Apple M1
3 participants