Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test-suite from original (Dropbox's) Djinni repository #17

Merged
merged 16 commits into from
Mar 21, 2021

Conversation

freitass
Copy link
Contributor

Adding tests for Java and Objective-C. The tests are located in the test-suite folder. “Djinni” code (enums, records and interfaces) for the test is generated from Djinni IDL at build time. The generated code is placed on the build directory.

Djinni version for code generation is specified in the tool-versions file. An alternative djinni command can be provided with the CMake option DJINNI_EXECUTABLE_PATH.

I’ve added a custom CMake command for the Djinni generator at test-suite/Djinni.cmake (I wonder if the generator project shouldn’t provide it instead).

@a4z
Copy link
Contributor

a4z commented Mar 20, 2021

I wonder what needs to be donethat the github action is actually executed for the PR.
It seems the current on: [push] does not trigger the build/test actions for a PR, or do I oversee something?

@freitass
Copy link
Contributor Author

I was asking myself the same question. I thought there was some config on the repository that I could not see. The generator repo has this:

name: CI
on:
  push:
    branches:
    - '*'
  pull_request:
    branches:
      - main

Should we have the same?

@freitass
Copy link
Contributor Author

Pushed minimal changes to have it run for the pull request.

Copy link
Contributor

@a4z a4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome PR!

CMakeLists.txt Outdated Show resolved Hide resolved
Co-authored-by: Harald <harald.achitz@gmail.com>
@a4z a4z merged commit 9fd3a43 into cross-language-cpp:main Mar 21, 2021
@freitass freitass deleted the test-suite branch August 29, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants