-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test-suite from original (Dropbox's) Djinni repository #17
Conversation
I wonder what needs to be donethat the github action is actually executed for the PR. |
I was asking myself the same question. I thought there was some config on the repository that I could not see. The generator repo has this:
Should we have the same? |
Pushed minimal changes to have it run for the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome PR!
Co-authored-by: Harald <harald.achitz@gmail.com>
Adding tests for Java and Objective-C. The tests are located in the
test-suite
folder. “Djinni” code (enums, records and interfaces) for the test is generated from Djinni IDL at build time. The generated code is placed on the build directory.Djinni version for code generation is specified in the
tool-versions
file. An alternativedjinni
command can be provided with the CMake optionDJINNI_EXECUTABLE_PATH
.I’ve added a custom CMake command for the Djinni generator at
test-suite/Djinni.cmake
(I wonder if the generator project shouldn’t provide it instead).