Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP-6818 : PanModal BackgroundInteraction 추가 #5

Closed
wants to merge 1 commit into from
Closed

APP-6818 : PanModal BackgroundInteraction 추가 #5

wants to merge 1 commit into from

Conversation

zzisun
Copy link

@zzisun zzisun commented Apr 20, 2023 •
edited
Loading

Reviewer

  • 1st :
  • 2nd :

Background

지라티켓: https://croquis.atlassian.net/browse/APP-6818

Changes

  • background interaction mode가 추가되었습니다.
    .dismiss - Taps dismiss the modal immediately (default)
    .forward - Touches are forwarded to the lower window (In most cases it would be the application main window that will handle it
    .none - Absorbs touches. The modal does nothing (Swallows the touch)
// Example
class MyPanModal: UIViewController, PanModalPresentable {

    ...

    var backgroundInteraction: PanModalBackgroundInteraction {
        return .forward
    }

}

Test Guide

Important

Related issue - slackhq#100

@zzisun zzisun added the enhancement New feature or request label Apr 20, 2023
@zzisun zzisun self-assigned this Apr 20, 2023
@zzisun zzisun marked this pull request as ready for review April 20, 2023 05:29
@zzisun
APP-6818 : PanModal BackgroundInteraction 추가
ec59f53 
addGestureRecognizer 제거

dismiss 함수 수정

wrapperVC에 background interaction 추가
@zzisun zzisun force-pushed the feature/APP-6818-background-interaction branch from c9bba50 to ec59f53 Compare April 21, 2023 05:55
@zzisun
Copy link
Author

zzisun commented Apr 24, 2023

추가 이슈가 있어서, 해결 후 요청드리겠습니다 🙏

@zzisun zzisun closed this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zzisun zzisun

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zzisun