Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce policy list/read capabilities #70

Merged
merged 3 commits into from
May 15, 2024
Merged

Conversation

cpaillet
Copy link
Contributor

@cpaillet cpaillet commented May 13, 2024

Refactor consul.acl
move token to consul.acl.token
create consul.acl.policies

Copy link
Contributor

@mbrulatout mbrulatout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some files need to be moved

tests/api/test_acl.py Show resolved Hide resolved
@cpaillet cpaillet force-pushed the master branch 16 times, most recently from a1a0e44 to 039cd6e Compare May 14, 2024 15:59
@mbrulatout
Copy link
Contributor

another PR is needed to change the dir structure.

cpaillet added 3 commits May 15, 2024 11:56
Refactor consul.acl as consul.acl.token in preparation for upcoming review and eventual integration of consul.acl.policy.
move token code to acl/token.py
add acl.policy.list and acl.policy.read
@cpaillet cpaillet force-pushed the master branch 2 times, most recently from b2c7434 to 3c6a356 Compare May 15, 2024 12:25
@mbrulatout mbrulatout changed the title Refactor consul.acl Introduce policy list/read capabilities May 15, 2024
@mbrulatout mbrulatout self-requested a review May 15, 2024 12:27
@cpaillet cpaillet merged commit 579a991 into criteo:master May 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants