Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add probing on restore snapshot feature #9

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

ashangit
Copy link

@ashangit ashangit commented Mar 2, 2021

Check that the durability index can well be restored from a specific snapshot policy
Only available with ES 7 as it rely on snapshot policy

@ashangit ashangit requested review from jfwm2, geobeau and Dveim March 2, 2021 11:07
Check that the durability index can well be restored from a specific snapshot policy
Only available with ES 7 as it rely on snapshot policy
Copy link

@jfwm2 jfwm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but overall, it looks good to me

@ashangit ashangit requested a review from jfwm2 March 2, 2021 13:52
Copy link

@jfwm2 jfwm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashangit ashangit merged commit a3a5dfc into criteo-forks:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants