✨ Add usage of a specific endpoint port #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a message on the commit to explain the intent of the change. It's not clear why we need to override the port and why we need a specific port for authentication. |
When pulling cluster from Consul, the port exposed is not necessarily the one that must be used in order to authenticate on the cluster. This feature allows to set a different endpoint pot to authenticate on the ElasticSearch cluster. By default, the endpoint port is the one exposed in Consul. Signed-off-by: f.bouzghaia <f.bouzghaia@criteo.com>
geobeau
requested changes
Aug 23, 2023
cmd/serve.go
Outdated
| @@ -19,6 +19,7 @@ type ServeCmd struct { | |||
| CleaningPeriod time.Duration `default:"600s" help:"prometheus metrics cleaning interval (for vanished nodes)"` | |||
| ElasticsearchConsulTag string `default:"maintenance-elasticsearch" help:"elasticsearch consul tag"` | |||
| ElasticsearchEndpointSuffix string `default:".service.{dc}.foo.bar" help:"Suffix to add after the consul service name to create a valid domain name"` | |||
| ElasticsearchEndpointPort int `default:"-1" help:"Elasticsearch port used for cluster authentication"` | |||
There was a problem hiding this comment.
Default should be 0 to be consistent with how Golang handle defaults (int defaults to 0).
cmd/serve.go
Outdated
| @@ -19,6 +19,7 @@ type ServeCmd struct { | |||
| CleaningPeriod time.Duration `default:"600s" help:"prometheus metrics cleaning interval (for vanished nodes)"` | |||
| ElasticsearchConsulTag string `default:"maintenance-elasticsearch" help:"elasticsearch consul tag"` | |||
| ElasticsearchEndpointSuffix string `default:".service.{dc}.foo.bar" help:"Suffix to add after the consul service name to create a valid domain name"` | |||
| ElasticsearchEndpointPort int `default:"-1" help:"Elasticsearch port used for cluster authentication"` | |||
There was a problem hiding this comment.
You specify cluster authentication but the port will be used for all cluster levels calls (snapshot, durability, ...)
added 2 commits
August 23, 2023 16:05
Default value for int is 0 for GoLang Signed-off-by: f.bouzghaia <f.bouzghaia@criteo.com>
Signed-off-by: f.bouzghaia <f.bouzghaia@criteo.com>
geobeau
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pulling cluster from Consul, the port exposed is not
necessarily the one that must be used in order to authenticate
on the cluster. This feature allows to set a different endpoint
pot to authenticate on the ElasticSearch cluster.
By default, the endpoint port is the one exposed in Consul.