Make keyword arguments delegation compatible with ruby v3 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annih
requested changes
Nov 23, 2022
libraries/choregraphie.rb
Outdated
| @@ -44,10 +44,11 @@ def initialize(name, &block) | |||
| # read all available primitives and make them available with a method | |||
| # using their name. It allows to call `check_file '/tmp/titi'` to | |||
| # instantiate the CheckFile primitive | |||
| delegated_args = RUBY_VERSION < '3' ? '*args, &block' : '*args, **kwargs, &block' | |||
There was a problem hiding this comment.
Here and below please use RUBY_VERSION.to_i < 3; your code works ... until we get to ruby 10
There was a problem hiding this comment.
Sure, will do! I hope we will able to drop ruby 2.7 support and remove this fix before Ruby v10, but yes :)
Annih
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How keyword arguments are passed has changed with ruby v3, they now have to be explicitly delegated, see https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
This patch add compatibility with Ruby v3 (which is embedded in recent versions of Chef), but also keep this cookbook functional with lower versions.