Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mailgun.cr #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vectorselector
Copy link

Updated mailgun.cr for Crystal 0.31.1 per Crystal API breaking change crystal-lang/crystal#7085

Updated mailgun.cr for Crystal 0.31.1 per Crystal API breaking change crystal-lang/crystal#7085
@crisward
Copy link
Owner

crisward commented Nov 4, 2019

@vectorselector Thanks for taking the time to submit these pull requests.

I'm not actively using crystal at the moment, but have some projects which rely on this repo and and older version of crystal that this was programmed to work with.

So although I'll be happy to merge these changes in, it will probably won't be a for a while.

Thanks again.

@vectorselector
Copy link
Author

vectorselector commented Nov 8, 2019

Oh, I did that with a couple projects pegged at Crystal 0.25.1 via crenv
I usually then pull the repo local under the project directory as such:
mailer: path: crystal_libraries/mailer

vs

mailer: github: crisward/mailer

@spicybackend
Copy link

Thanks heaps for the PRs @vectorselector! Also taking on your dependency suggestion here and it's working wonders. It'd be awesome to get these changes merged and released sometime soon though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants