Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start bacon in background #18

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Start bacon in background #18

merged 3 commits into from
Jan 19, 2025

Conversation

crisidev
Copy link
Owner

Fixes #16

@crisidev crisidev marked this pull request as ready for review January 16, 2025 17:30
@crisidev
Copy link
Owner Author

This is still missing some README updates.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 40.31008% with 77 lines in your changes missing coverage. Please review.

Project coverage is 53.89%. Comparing base (98669a9) to head (e4e5565).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/bacon.rs 53.26% 40 Missing and 3 partials ⚠️
src/lsp.rs 0.00% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   55.68%   53.89%   -1.79%     
==========================================
  Files           4        4              
  Lines         625      744     +119     
  Branches      625      744     +119     
==========================================
+ Hits          348      401      +53     
- Misses        264      328      +64     
- Partials       13       15       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crisidev
Copy link
Owner Author

This MR also addresses #17

@crisidev crisidev merged commit 1df3114 into main Jan 19, 2025
5 checks passed
@crisidev crisidev deleted the start-bacon branch January 19, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start bacon in background
2 participants