Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item types, activities carcass, qa tools #7

Merged
merged 29 commits into from
Sep 6, 2023
Merged

Conversation

TemirkhanN
Copy link
Contributor

Feature:

  • Introduced item types. Currently consumables have an impact. Currency is also for tracking if item is sellable.
  • Acitivities are generalized. Since they work in the same manner, all they need is the reward data filled in data/activity_option.yaml
  • Hunting system enhanced. Now we issue rewards for each slain mob and can track that info(planning to add some related quests). Some bugs fixed.

Tech:

  • Added static code analyzer(phpstan. helps to find bugs earlier).
  • Codesniffer (phpcs. just to ensure that the codebase looks the same)
  • A few additional tests. Coverage around 50% at this point.
  • Some refactoring performed according introduced tools.

@crilleaz crilleaz merged commit 5de2dbd into crilleaz:main Sep 6, 2023
@skxnxt skxnxt mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants