-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no more sql-injections; fixed dungeon exp rewarding; refactoring. #2
Conversation
The breaking is caused by selecting the experience from exp_table, while the user has equal or more than what is the highest in the table, was not finished with that part, added some 20 levels or so! Other than that, i'll go through as soon as i get some free time, but first glance it looks nothing but good. I don't know if doctrine/dbal is necessary, but I don't mind! You are doing great work here, much appreciated! |
It's too big and very messy in terms of amount of changes. Will be difficult to dive in and review by all means.
These changes are backward compatible - no behavior was changed.
This mr mostly ensures that there are no ambiguous cases when something happens implicitly.
./tabs/
directory now only renders the data and handles the signals. All changes in the database happens only through./src/
.Database interaction is now happening through
https://github.com/doctrine/dbal
. It was not essential but simplifies some things(changing database driver without rewriting an app at any moment).Also, the wrapper has been adjusted to execute prepared statements so, no need for
mysql_real_escape_string
and so on.To prevent the injection one can now use
Behavior changing
Breaking
exp_table
, then his level can not be calculated and status-bar fails due to that error.