Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicates and segregated code blocks #1

Merged
merged 5 commits into from
Aug 3, 2023

Conversation

TemirkhanN
Copy link
Contributor

To simplify navigation and readability segregated code blocks into three main chunks. Player, tabs and launcher.

Launcher bootstraps game engine, sessions and tabs.
Tabs are basically pages organised as bunch of controller(which they previously were, so the only thing that changed here is that we try to reduce amount of global variables they use).
Player is the only explicit model extracted from engine.php for now. It encapsulates player-related logic and isolates database interaction.

Still a bunch of things to refactor but further manipulations and adjustments have to become easier from this point.

@crilleaz
Copy link
Owner

crilleaz commented Aug 3, 2023

I like it, I think its the way moving forward. And you're right, there's a lot of left overs and just general comments to myself, there is active security issues that needs to be adressed

@crilleaz crilleaz marked this pull request as ready for review August 3, 2023 17:30
@crilleaz crilleaz merged commit 8293905 into crilleaz:main Aug 3, 2023
@TemirkhanN
Copy link
Contributor Author

@crilleaz do you mind if we move towards using composer ?
It will resolve autoloading issues and allow us to use some 3rd party libraries such as database and http wrappers.

@crilleaz
Copy link
Owner

crilleaz commented Aug 3, 2023

I believe the move has to be done, right now I don't have a environment that would support any higher than PHP 7.2 sadly.

@TemirkhanN
Copy link
Contributor Author

I will perform adjustments yet will be great if at some point you could to step in to implement/enhance features and share your vision on player interface.

If you need any assistance with php upgrade drop me a message. php 7.4 is the lowest you should aim for since it provides really good benefits.

@skxnxt skxnxt mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants