fix: Add validation fix output_file issue when have '/' #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythonbyte
commented
May 9, 2024
| return exported_result | ||
| except Exception: | ||
| pass | ||
| # sometimes the response contains valid JSON in the middle of text |
There was a problem hiding this comment.
This is my formatter adding 2 more spaces to properly ident this past code
bhancockio
pushed a commit
that referenced
this pull request
Jan 2, 2025
* fix: Add validation fix output_file issue when have / * fix: run black to format code * fix: run black to format code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue found from the Discord thread
https://discord.com/channels/1192246288507474000/1235083142520635392/threads/1237431294745378847
The solution is to validate the output_file before saving it, and removing the initial / sign so it can account for both local files and for directory creation.